New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --builder
option from rails
command
#9401
Remove --builder
option from rails
command
#9401
Conversation
sure! |
PR updated. |
whoops, hold on |
Missing to remove the methods in my last comment |
Ability to use a custom builder by passing `--builder` (or `-b`) has been removed. Consider using application template instead. See this guide for more detail: http://guides.rubyonrails.org/rails_application_templates.html
I ended up removed the whole class, since it's now a no-op. |
Remove `--builder` option from `rails` command
❤️ 💚 💙 💛 💜 |
I'll let core team speak on this one (/cc @dhh). I think we didn't see enough usage on this in the real world, so it got removed during the cleanup. |
I've never used this, so I'd need some context as to what this is used for to chime in. Can anyone give some real-world examples of how and for what they're using this? |
I have two cases where i used it myself: Dummy app for testing (which is generated when generating a new engine, but their does not exists any rake method to create it manually), and custom engines. RefineryCMS is another good example where they have created a whole new custom generator for engines, instead of using all the methods already available in the internal Rails engine builder (see: engine_generator.rb and extension_generator.rb). |
Another solution would be to make it simpler to make a generator with a custom builder that inherits from the existing builders, and add documentation about this. |
Ability to use a custom builder by passing
--builder
(or-b
) has been removed. Consider using application template instead. See this guide for more detail: http://guides.rubyonrails.org/rails_application_templates.html